]> git.itanic.dy.fi Git - linux-stable/commitdiff
selftests: net: mirror_gre_vlan_bridge_1q: Make an FDB entry static
authorPetr Machata <petrm@nvidia.com>
Fri, 23 Apr 2021 12:19:43 +0000 (14:19 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 May 2021 07:50:43 +0000 (09:50 +0200)
[ Upstream commit c8d0260cdd96fdccdef0509c4160e28a1012a5d7 ]

The FDB roaming test installs a destination MAC address on the wrong
interface of an FDB database and tests whether the mirroring fails, because
packets are sent to the wrong port. The test by mistake installs the FDB
entry as local. This worked previously, because drivers were notified of
local FDB entries in the same way as of static entries. However that has
been fixed in the commit 6ab4c3117aec ("net: bridge: don't notify switchdev
for local FDB addresses"), and local entries are not notified anymore. As a
result, the HW is not reconfigured for the FDB roam, and mirroring keeps
working, failing the test.

To fix the issue, mark the FDB entry as static.

Fixes: 9c7c8a82442c ("selftests: forwarding: mirror_gre_vlan_bridge_1q: Add more tests")
Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/net/forwarding/mirror_gre_vlan_bridge_1q.sh

index c02291e9841e326317cded84065b47b16af42130..880e3ab9d088df56ca84da61fd1b870d6c5f5443 100755 (executable)
@@ -271,7 +271,7 @@ test_span_gre_fdb_roaming()
 
        while ((RET == 0)); do
                bridge fdb del dev $swp3 $h3mac vlan 555 master 2>/dev/null
-               bridge fdb add dev $swp2 $h3mac vlan 555 master
+               bridge fdb add dev $swp2 $h3mac vlan 555 master static
                sleep 1
                fail_test_span_gre_dir $tundev ingress