]> git.itanic.dy.fi Git - linux-stable/commitdiff
net: sched: move rtm_tca_policy declaration to include file
authorEric Dumazet <edumazet@google.com>
Tue, 6 Jun 2023 11:42:33 +0000 (11:42 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jun 2023 08:59:56 +0000 (10:59 +0200)
[ Upstream commit 886bc7d6ed3357975c5f1d3c784da96000d4bbb4 ]

rtm_tca_policy is used from net/sched/sch_api.c and net/sched/cls_api.c,
thus should be declared in an include file.

This fixes the following sparse warning:
net/sched/sch_api.c:1434:25: warning: symbol 'rtm_tca_policy' was not declared. Should it be static?

Fixes: e331473fee3d ("net/sched: cls_api: add missing validation of netlink attributes")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/net/pkt_sched.h
net/sched/cls_api.c

index d1585b54fb0bd0b0fe59563fd04b2d6ba5b8f487..2d932834ed5bfb0cb24e1ddf1f8062c54e76d59b 100644 (file)
@@ -124,6 +124,8 @@ static inline void qdisc_run(struct Qdisc *q)
        }
 }
 
+extern const struct nla_policy rtm_tca_policy[TCA_MAX + 1];
+
 /* Calculate maximal size of packet seen by hard_start_xmit
    routine of this device.
  */
index 49777da9f2634c8e9f63275abde2d67e3a52d8bc..3e5b10bec0cf7627cc47992e52df57dc7c8a54e6 100644 (file)
@@ -40,8 +40,6 @@
 #include <net/tc_act/tc_mpls.h>
 #include <net/flow_offload.h>
 
-extern const struct nla_policy rtm_tca_policy[TCA_MAX + 1];
-
 /* The list of all installed classifier types */
 static LIST_HEAD(tcf_proto_base);