]> git.itanic.dy.fi Git - linux-stable/commitdiff
drm/i915: Drop has_reset_engine from device info
authorJosé Roberto de Souza <jose.souza@intel.com>
Thu, 5 May 2022 19:35:20 +0000 (12:35 -0700)
committerJosé Roberto de Souza <jose.souza@intel.com>
Fri, 6 May 2022 16:28:13 +0000 (09:28 -0700)
No need to have this parameter in intel_device_info struct
as all platforms with graphics version 7 or newer can reset engines.

As a side effect of the of removal this flag, it will not be printed
in dmesg during driver load anymore and developers will have to rely
on to check the macro and compare with platform being used and IP
versions of it.

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220505193524.276400-3-jose.souza@intel.com
drivers/gpu/drm/i915/gt/intel_reset.c
drivers/gpu/drm/i915/i915_pci.c
drivers/gpu/drm/i915/intel_device_info.h

index 5422a3b84bd44ab0ab1d965bb9184c08410e4ea8..894f17f8b4cea8b9922a61d3bcc26d872f4453fa 100644 (file)
@@ -699,7 +699,7 @@ bool intel_has_reset_engine(const struct intel_gt *gt)
        if (gt->i915->params.reset < 2)
                return false;
 
-       return INTEL_INFO(gt->i915)->has_reset_engine;
+       return GRAPHICS_VER(gt->i915) >= 7;
 }
 
 int intel_reset_guc(struct intel_gt *gt)
index 1973d8e047f0f8454c4950800a2302155f422669..b86e67c69458466e2f983157b756a806d24ac46e 100644 (file)
@@ -456,7 +456,6 @@ static const struct intel_device_info snb_m_gt2_info = {
        .has_coherent_ggtt = true, \
        .has_llc = 1, \
        .has_rc6p = 1, \
-       .has_reset_engine = true, \
        .has_rps = true, \
        .dma_mask_size = 40, \
        .ppgtt_type = INTEL_PPGTT_ALIASING, \
@@ -514,7 +513,6 @@ static const struct intel_device_info vlv_info = {
        .display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B),
        .display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B),
        .has_runtime_pm = 1,
-       .has_reset_engine = true,
        .has_rps = true,
        .display.has_gmch = 1,
        .display.has_hotplug = 1,
@@ -618,7 +616,6 @@ static const struct intel_device_info chv_info = {
        .dma_mask_size = 39,
        .ppgtt_type = INTEL_PPGTT_FULL,
        .ppgtt_size = 32,
-       .has_reset_engine = 1,
        .has_snoop = true,
        .has_coherent_ggtt = false,
        .display_mmio_offset = VLV_DISPLAY_BASE,
@@ -700,7 +697,6 @@ static const struct intel_device_info skl_gt4_info = {
        .dma_mask_size = 39, \
        .ppgtt_type = INTEL_PPGTT_FULL, \
        .ppgtt_size = 48, \
-       .has_reset_engine = 1, \
        .has_snoop = true, \
        .has_coherent_ggtt = false, \
        .display.has_ipc = 1, \
@@ -1003,7 +999,6 @@ static const struct intel_device_info adl_p_info = {
        .has_logical_ring_contexts = 1, \
        .has_logical_ring_elsq = 1, \
        .has_mslices = 1, \
-       .has_reset_engine = 1, \
        .has_rps = 1, \
        .has_runtime_pm = 1, \
        .ppgtt_size = 48, \
index 68af6f89a366181278c5955197cf870e27d046f9..53777e14fa850ba39d68fd9bae8a90d90c9495e4 100644 (file)
@@ -137,7 +137,6 @@ enum intel_ppgtt_type {
        func(has_64k_pages); \
        func(needs_compact_pt); \
        func(gpu_reset_clobbers_display); \
-       func(has_reset_engine); \
        func(has_4tile); \
        func(has_flat_ccs); \
        func(has_global_mocs); \