]> git.itanic.dy.fi Git - linux-stable/commitdiff
kconfig: remove unused code for S_DEF_AUTO in conf_read_simple()
authorMasahiro Yamada <masahiroy@kernel.org>
Sat, 18 Nov 2023 07:59:08 +0000 (16:59 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Tue, 28 Nov 2023 02:22:51 +0000 (11:22 +0900)
The 'else' arm here is unreachable in practical use cases.

include/config/auto.conf does not include "# CONFIG_... is not set"
line unless it is manually hacked.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/kconfig/confdata.c

index 556b7f087dbb5562a0f746244bd5bbb70cb9c49d..92e8e37aca4d1eafdbb5a76e643988e1635007d3 100644 (file)
@@ -436,20 +436,15 @@ int conf_read_simple(const char *name, int def)
                        *p++ = 0;
                        if (strncmp(p, "is not set", 10))
                                continue;
-                       if (def == S_DEF_USER) {
-                               sym = sym_find(line + 2 + strlen(CONFIG_));
-                               if (!sym) {
-                                       if (warn_unknown)
-                                               conf_warning("unknown symbol: %s",
-                                                            line + 2 + strlen(CONFIG_));
 
-                                       conf_set_changed(true);
-                                       continue;
-                               }
-                       } else {
-                               sym = sym_lookup(line + 2 + strlen(CONFIG_), 0);
-                               if (sym->type == S_UNKNOWN)
-                                       sym->type = S_BOOLEAN;
+                       sym = sym_find(line + 2 + strlen(CONFIG_));
+                       if (!sym) {
+                               if (warn_unknown)
+                                       conf_warning("unknown symbol: %s",
+                                                    line + 2 + strlen(CONFIG_));
+
+                               conf_set_changed(true);
+                               continue;
                        }
                        if (sym->flags & def_flags) {
                                conf_warning("override: reassigning to symbol %s", sym->name);