]> git.itanic.dy.fi Git - linux-stable/commitdiff
bcache: silence static checker warning
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 6 Sep 2017 06:26:00 +0000 (14:26 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jan 2020 09:24:40 +0000 (10:24 +0100)
commit da22f0eea555baf9b0a84b52afe56db2052cfe8d upstream.

In olden times, closure_return() used to have a hidden return built in.
We removed the hidden return but forgot to add a new return here.  If
"c" were NULL we would oops on the next line, but fortunately "c" is
never NULL.  Let's just remove the if statement.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/bcache/super.c

index 080f9afcde8da494f05fb884c08f91e6767e1039..526e9d5a4fb16f801a29fb79d509d8ebbf4e9114 100644 (file)
@@ -1398,9 +1398,6 @@ static void cache_set_flush(struct closure *cl)
        struct btree *b;
        unsigned i;
 
-       if (!c)
-               closure_return(cl);
-
        bch_cache_accounting_destroy(&c->accounting);
 
        kobject_put(&c->internal);