]> git.itanic.dy.fi Git - linux-stable/commitdiff
xfs: slightly tweak an assert in xfs_fs_map_blocks
authorChristoph Hellwig <hch@lst.de>
Sat, 24 Sep 2022 12:56:41 +0000 (18:26 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Sep 2022 09:04:09 +0000 (11:04 +0200)
commit 88cdb7147b21b2d8b4bd3f3d95ce0bffd73e1ac3 upstream.

We should never see delalloc blocks for a pNFS layout, write or not.
Adjust the assert to check for that.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Acked-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Chandan Babu R <chandan.babu@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/xfs/xfs_pnfs.c

index f63fe8d924a363cf6f680693d900af6019922f10..058af699e046c179291c534609e4cc706bfa0baf 100644 (file)
@@ -147,11 +147,11 @@ xfs_fs_map_blocks(
        if (error)
                goto out_unlock;
 
+       ASSERT(!nimaps || imap.br_startblock != DELAYSTARTBLOCK);
+
        if (write) {
                enum xfs_prealloc_flags flags = 0;
 
-               ASSERT(imap.br_startblock != DELAYSTARTBLOCK);
-
                if (!nimaps || imap.br_startblock == HOLESTARTBLOCK) {
                        /*
                         * xfs_iomap_write_direct() expects to take ownership of