]> git.itanic.dy.fi Git - linux-stable/commitdiff
i2c: wmt: Fix an error handling path in wmt_i2c_probe()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 5 Jan 2024 14:39:35 +0000 (15:39 +0100)
committerWolfram Sang <wsa+renesas@sang-engineering.com>
Fri, 8 Mar 2024 09:10:26 +0000 (10:10 +0100)
wmt_i2c_reset_hardware() calls clk_prepare_enable(). So, should an error
occur after it, it should be undone by a corresponding
clk_disable_unprepare() call, as already done in the remove function.

Fixes: 560746eb79d3 ("i2c: vt8500: Add support for I2C bus on Wondermedia SoCs")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-wmt.c

index ec2a8da134e56d01be06588551db26bca47caef4..198afee5233c3d65df7552eb3343fe4d4e5d7488 100644 (file)
@@ -378,11 +378,15 @@ static int wmt_i2c_probe(struct platform_device *pdev)
 
        err = i2c_add_adapter(adap);
        if (err)
-               return err;
+               goto err_disable_clk;
 
        platform_set_drvdata(pdev, i2c_dev);
 
        return 0;
+
+err_disable_clk:
+       clk_disable_unprepare(i2c_dev->clk);
+       return err;
 }
 
 static void wmt_i2c_remove(struct platform_device *pdev)