]> git.itanic.dy.fi Git - linux-stable/commitdiff
perf dwarf-aux: Add die_get_scopes() alternative to dwarf_getscopes()
authorNamhyung Kim <namhyung@kernel.org>
Thu, 9 Nov 2023 23:59:25 +0000 (15:59 -0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 10 Nov 2023 12:04:08 +0000 (09:04 -0300)
The die_get_scopes() returns the number of enclosing DIEs for the given
address and it fills an array of DIEs like dwarf_getscopes().  But it
doesn't follow the abstract origin of inlined functions as we want
information of the concrete instance.  This is needed to check the
location of parameters and local variables properly.  Users can check
the origin separately if needed.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: linux-toolchains@vger.kernel.org
Cc: linux-trace-devel@vger.kernel.org
Link: https://lore.kernel.org/r/20231110000012.3538610-7-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/dwarf-aux.c
tools/perf/util/dwarf-aux.h

index adef2635587de5f2a962d3b6fe2e92ee3f92998e..10aa32334d6f276222f999ce26f612d031efcbef 100644 (file)
@@ -1425,3 +1425,56 @@ void die_skip_prologue(Dwarf_Die *sp_die, Dwarf_Die *cu_die,
 
        *entrypc = postprologue_addr;
 }
+
+/* Internal parameters for __die_find_scope_cb() */
+struct find_scope_data {
+       /* Target instruction address */
+       Dwarf_Addr pc;
+       /* Number of scopes found [output] */
+       int nr;
+       /* Array of scopes found, 0 for the outermost one. [output] */
+       Dwarf_Die *scopes;
+};
+
+static int __die_find_scope_cb(Dwarf_Die *die_mem, void *arg)
+{
+       struct find_scope_data *data = arg;
+
+       if (dwarf_haspc(die_mem, data->pc)) {
+               Dwarf_Die *tmp;
+
+               tmp = realloc(data->scopes, (data->nr + 1) * sizeof(*tmp));
+               if (tmp == NULL)
+                       return DIE_FIND_CB_END;
+
+               memcpy(tmp + data->nr, die_mem, sizeof(*die_mem));
+               data->scopes = tmp;
+               data->nr++;
+               return DIE_FIND_CB_CHILD;
+       }
+       return DIE_FIND_CB_SIBLING;
+}
+
+/**
+ * die_get_scopes - Return a list of scopes including the address
+ * @cu_die: a compile unit DIE
+ * @pc: the address to find
+ * @scopes: the array of DIEs for scopes (result)
+ *
+ * This function does the same as the dwarf_getscopes() but doesn't follow
+ * the origins of inlined functions.  It returns the number of scopes saved
+ * in the @scopes argument.  The outer scope will be saved first (index 0) and
+ * the last one is the innermost scope at the @pc.
+ */
+int die_get_scopes(Dwarf_Die *cu_die, Dwarf_Addr pc, Dwarf_Die **scopes)
+{
+       struct find_scope_data data = {
+               .pc = pc,
+       };
+       Dwarf_Die die_mem;
+
+       die_find_child(cu_die, __die_find_scope_cb, &data, &die_mem);
+
+       *scopes = data.scopes;
+       return data.nr;
+}
index 4f5d0211ee4f23349549b9105a9aff63f6bcc459..f9d765f80fb024332c4946d26272e5e5829a3da9 100644 (file)
@@ -129,6 +129,9 @@ bool die_is_optimized_target(Dwarf_Die *cu_die);
 void die_skip_prologue(Dwarf_Die *sp_die, Dwarf_Die *cu_die,
                       Dwarf_Addr *entrypc);
 
+/* Get the list of including scopes */
+int die_get_scopes(Dwarf_Die *cu_die, Dwarf_Addr pc, Dwarf_Die **scopes);
+
 #ifdef HAVE_DWARF_GETLOCATIONS_SUPPORT
 
 /* Get byte offset range of given variable DIE */