]> git.itanic.dy.fi Git - linux-stable/commitdiff
ASoC: SOF: Intel: Initialize chip in hda_sdw_check_wakeen_irq()
authorNathan Chancellor <nathan@kernel.org>
Wed, 9 Aug 2023 18:12:07 +0000 (11:12 -0700)
committerMark Brown <broonie@kernel.org>
Wed, 9 Aug 2023 23:27:23 +0000 (00:27 +0100)
Clang warns (or errors with CONFIG_WERROR):

  sound/soc/sof/intel/hda.c:423:6: error: variable 'chip' is uninitialized when used here [-Werror,-Wuninitialized]
    423 |         if (chip && chip->check_sdw_wakeen_irq)
        |             ^~~~
  sound/soc/sof/intel/hda.c:418:39: note: initialize the variable 'chip' to silence this warning
    418 |         const struct sof_intel_dsp_desc *chip;
        |                                              ^
        |                                               = NULL
  1 error generated.

Add the missing initialization, following the pattern of the other irq
functions.

Fixes: 9362ab78f175 ("ASoC: SOF: Intel: add abstraction for SoundWire wake-ups")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20230809-intel-hda-missing-chip-init-v1-1-61557ca6fa8a@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/intel/hda.c

index 04c748a72b137aa8a9028c6eb6548a82f5394539..15e6779efaa3bcc9e0dc16e6a92271930eba7a0f 100644 (file)
@@ -420,6 +420,7 @@ static bool hda_sdw_check_wakeen_irq(struct snd_sof_dev *sdev)
        if (!(interface_mask & BIT(SOF_DAI_INTEL_ALH)))
                return false;
 
+       chip = get_chip_info(sdev->pdata);
        if (chip && chip->check_sdw_wakeen_irq)
                return chip->check_sdw_wakeen_irq(sdev);