]> git.itanic.dy.fi Git - linux-stable/commitdiff
mlxsw: pci: Fix missing error checking
authorIdo Schimmel <idosch@nvidia.com>
Thu, 23 Nov 2023 12:01:35 +0000 (13:01 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 25 Nov 2023 19:21:15 +0000 (19:21 +0000)
I accidentally removed the error checking after issuing the reset.
Restore it.

Fixes: f257c73e5356 ("mlxsw: pci: Add support for new reset flow")
Reported-by: Coverity Scan <scan-admin@coverity.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/pci.c

index 0d58f13a7c7d861f6c6f1e17ebd3d4bbafad09ac..af99bf17eb36de0793b008c063c2a93c6c5b22c8 100644 (file)
@@ -1561,6 +1561,8 @@ mlxsw_pci_reset(struct mlxsw_pci *mlxsw_pci, const struct pci_device_id *id)
                pci_dbg(pdev, "Starting software reset flow\n");
                err = mlxsw_pci_reset_sw(mlxsw_pci);
        }
+       if (err)
+               return err;
 
        err = mlxsw_pci_sys_ready_wait(mlxsw_pci, id, &sys_status);
        if (err) {