]> git.itanic.dy.fi Git - linux-stable/commitdiff
PCI/DPC: Print all TLP Prefixes, not just the first
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Thu, 18 Jan 2024 11:08:15 +0000 (13:08 +0200)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:17:00 +0000 (18:17 -0400)
[ Upstream commit 6568d82512b0a64809acff3d7a747362fa4288c8 ]

The TLP Prefix Log Register consists of multiple DWORDs (PCIe r6.1 sec
7.9.14.13) but the loop in dpc_process_rp_pio_error() keeps reading from
the first DWORD, so we print only the first PIO TLP Prefix (duplicated
several times), and we never print the second, third, etc., Prefixes.

Add the iteration count based offset calculation into the config read.

Fixes: f20c4ea49ec4 ("PCI/DPC: Add eDPC support")
Link: https://lore.kernel.org/r/20240118110815.3867-1-ilpo.jarvinen@linux.intel.com
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
[bhelgaas: add user-visible details to commit log]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pci/pcie/dpc.c

index 94111e4382413dc57ff10a079e1bdfc50c0e978e..e5d7c12854fa027c548781d53a01904cb3dea7fd 100644 (file)
@@ -234,7 +234,7 @@ static void dpc_process_rp_pio_error(struct pci_dev *pdev)
 
        for (i = 0; i < pdev->dpc_rp_log_size - 5; i++) {
                pci_read_config_dword(pdev,
-                       cap + PCI_EXP_DPC_RP_PIO_TLPPREFIX_LOG, &prefix);
+                       cap + PCI_EXP_DPC_RP_PIO_TLPPREFIX_LOG + i * 4, &prefix);
                pci_err(pdev, "TLP Prefix Header: dw%d, %#010x\n", i, prefix);
        }
  clear_status: