]> git.itanic.dy.fi Git - linux-stable/commitdiff
power: supply: ab8500: Remove flush_scheduled_work() call.
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Thu, 9 Jun 2022 04:58:04 +0000 (13:58 +0900)
committerSebastian Reichel <sre@kernel.org>
Sat, 16 Jul 2022 23:00:25 +0000 (01:00 +0200)
It seems to me that ab8500 driver is using dedicated workqueues and
is not calling schedule{,_delayed}_work{,_on}(). Then, there will be
no work to flush using flush_scheduled_work().

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/ab8500_btemp.c
drivers/power/supply/ab8500_chargalg.c
drivers/power/supply/ab8500_charger.c
drivers/power/supply/ab8500_fg.c

index b7e842dff5678c4e350749fa3d5f3cfd0c126df2..863fabe05bdcf84bb824417b7b814a6c283bbd8d 100644 (file)
@@ -697,7 +697,6 @@ static void ab8500_btemp_unbind(struct device *dev, struct device *master,
 
        /* Delete the work queue */
        destroy_workqueue(di->btemp_wq);
-       flush_scheduled_work();
 }
 
 static const struct component_ops ab8500_btemp_component_ops = {
index d56147f7eaec68f0d7ca6d4f0e2520001a2d5045..ae4be553f4248beb4e60369db0e4eb8a2cd0b7c2 100644 (file)
@@ -1769,7 +1769,6 @@ static void ab8500_chargalg_unbind(struct device *dev, struct device *master,
 
        /* Delete the work queue */
        destroy_workqueue(di->chargalg_wq);
-       flush_scheduled_work();
 }
 
 static const struct component_ops ab8500_chargalg_component_ops = {
index 9701c3e735e7ff8cd54d571219738cc9a299411f..62c958b9ec370f99548599ccd23ee1e3e427d071 100644 (file)
@@ -3377,8 +3377,6 @@ static void ab8500_charger_unbind(struct device *dev)
        /* Delete the work queue */
        destroy_workqueue(di->charger_wq);
 
-       flush_scheduled_work();
-
        /* Unbind fg, btemp, algorithm */
        component_unbind_all(dev, di);
 }
index f6cf5eb97415c0fc8b5c56961cc4034f4d79c9e2..1c7c5a6a2d0add8303bbad07fb990fceb7162660 100644 (file)
@@ -3227,7 +3227,6 @@ static int ab8500_fg_remove(struct platform_device *pdev)
        struct ab8500_fg *di = platform_get_drvdata(pdev);
 
        destroy_workqueue(di->fg_wq);
-       flush_scheduled_work();
        component_del(&pdev->dev, &ab8500_fg_component_ops);
        list_del(&di->node);
        ab8500_fg_sysfs_exit(di);