]> git.itanic.dy.fi Git - linux-stable/commitdiff
pwm: stm32-lp: Don't modify HW state in .remove() callback
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wed, 7 Jul 2021 16:27:53 +0000 (18:27 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 26 Sep 2021 12:09:01 +0000 (14:09 +0200)
[ Upstream commit d44084c93427bb0a9261432db1a8ca76a42d805e ]

A consumer is expected to disable a PWM before calling pwm_put(). And if
they didn't there is hopefully a good reason (or the consumer needs
fixing). Also if disabling an enabled PWM was the right thing to do,
this should better be done in the framework instead of in each low level
driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pwm/pwm-stm32-lp.c

index 134c14621ee011c816830d26b1f7ac4974f40c40..945a8b2b85648c835ecdfa422df8fc61d488e2fa 100644 (file)
@@ -225,8 +225,6 @@ static int stm32_pwm_lp_remove(struct platform_device *pdev)
 {
        struct stm32_pwm_lp *priv = platform_get_drvdata(pdev);
 
-       pwm_disable(&priv->chip.pwms[0]);
-
        return pwmchip_remove(&priv->chip);
 }