]> git.itanic.dy.fi Git - linux-stable/commitdiff
ext4: Update comment in mpage_prepare_extent_to_map()
authorJan Kara <jack@suse.cz>
Wed, 29 Mar 2023 15:49:43 +0000 (17:49 +0200)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 14 Apr 2023 23:58:33 +0000 (19:58 -0400)
Since filemap_write_and_wait() is now enough to get journalled data to
final location update the comment in mpage_prepare_extent_to_map().

Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230329154950.19720-12-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/inode.c

index d43beb886a30bbfff7d4d8318b86643fe6f0ad63..c1888cd2a48f7504a17cecee2f9fb1a5202d2262 100644 (file)
@@ -2496,11 +2496,10 @@ static int mpage_prepare_extent_to_map(struct mpage_da_data *mpd)
                         * Just submit the page. For data=journal mode we
                         * first handle writeout of the page for checkpoint and
                         * only after that handle delayed page dirtying. This
-                        * is crutial so that forcing a transaction commit and
-                        * then calling filemap_write_and_wait() guarantees
-                        * current state of data is in its final location. Such
-                        * sequence is used for example by insert/collapse
-                        * range operations before discarding the page cache.
+                        * makes sure current data is checkpointed to the final
+                        * location before possibly journalling it again which
+                        * is desirable when the page is frequently dirtied
+                        * through a pin.
                         */
                        if (!mpd->can_map) {
                                WARN_ON_ONCE(sb->s_writers.frozen ==