dmaengine: dw-edma: Depend on DW_EDMA instead of selecting it

Kconfig "select" is discouraged for visible symbols like DW_EDMA because it
makes it possible to set DW_EDMA even if DW_EDMA depends on things that are
not set (see Documentation/kbuild/kconfig-language.txt).

Convert DW_EDMA_PCIE so it depends on DW_EDMA instead of selecting it.

There will likely be several future drivers that depend on DW_EDMA, so this
uses "if DW_EDMA" to enclose them all rather than repeating "depends on
DW_EDMA" for each.

[bhelgaas: split to separate patch, commit log]
Link: https://lore.kernel.org/r/20230113171409.30470-25-Sergey.Semin@baikalelectronics.ru
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/dma/dw-edma/Kconfig b/drivers/dma/dw-edma/Kconfig
index 7ff17b2db6a161da2f471eb463d87288f75fe5af..2b6f2679508d93b94b7efecd4e36d5902f7b4c99 100644 (file)
--- a/drivers/dma/dw-edma/Kconfig
+++ b/drivers/dma/dw-edma/Kconfig
@@ -9,11 +9,14 @@ config DW_EDMA
          Support the Synopsys DesignWare eDMA controller, normally
          implemented on endpoints SoCs.
 
+if DW_EDMA
+
 config DW_EDMA_PCIE
        tristate "Synopsys DesignWare eDMA PCIe driver"
        depends on PCI && PCI_MSI
-       select DW_EDMA
        help
          Provides a glue-logic between the Synopsys DesignWare
          eDMA controller and an endpoint PCIe device. This also serves
          as a reference design to whom desires to use this IP.
+
+endif # DW_EDMA