]> git.itanic.dy.fi Git - linux-stable/commitdiff
powerpc/fsl_pci: Remove of_node_put() when reference escaped out
authorLiang He <windhl@126.com>
Wed, 20 Jul 2022 12:45:57 +0000 (20:45 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 5 Sep 2022 07:30:29 +0000 (17:30 +1000)
In fsl_pci_assign_primary(), we should remove the of_node_put()
when breaking out of the for_each_matching_node() as the 'np'
is escaped out by global 'fsl_pci_primary'.

Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220720124557.1256243-1-windhl@126.com
arch/powerpc/sysdev/fsl_pci.c

index 4c3fd9f4cc7b618083ee6fed848587e01df23411..1ef7400ef244d588d4cc7fba26ce0319772bca36 100644 (file)
@@ -1146,7 +1146,6 @@ void __init fsl_pci_assign_primary(void)
        for_each_matching_node(np, pci_ids) {
                if (of_device_is_available(np)) {
                        fsl_pci_primary = np;
-                       of_node_put(np);
                        return;
                }
        }