]> git.itanic.dy.fi Git - linux-stable/commitdiff
drm: renesas: shmobile: Correct encoder/connector types
authorGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 15 Sep 2023 08:53:21 +0000 (10:53 +0200)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 16 Oct 2023 09:47:43 +0000 (11:47 +0200)
The first encoder output on the SH-Mobile LCD Controller is a DPI
parallel bus.  However, at the time of introduction of the driver, no
encoder or connector types were defined yet for the DPI parallel bus,
hence the driver used the ones for LVDS instead.

Adjust the types accordingly.

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/db500dd8356955d3471a1ccd68d90db9f9750ef9.1694767209.git.geert+renesas@glider.be
drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c

index 11dd2bc803e7cb6236a5092b3db39a79defe0279..fbfd906844da490c2f2d9760df66ea6a24212977 100644 (file)
@@ -598,7 +598,7 @@ int shmob_drm_encoder_create(struct shmob_drm_device *sdev)
        encoder->possible_crtcs = 1;
 
        ret = drm_simple_encoder_init(sdev->ddev, encoder,
-                                     DRM_MODE_ENCODER_LVDS);
+                                     DRM_MODE_ENCODER_DPI);
        if (ret < 0)
                return ret;
 
@@ -684,7 +684,7 @@ int shmob_drm_connector_create(struct shmob_drm_device *sdev,
        connector->display_info.height_mm = sdev->pdata->panel.height_mm;
 
        ret = drm_connector_init(sdev->ddev, connector, &connector_funcs,
-                                DRM_MODE_CONNECTOR_LVDS);
+                                DRM_MODE_CONNECTOR_DPI);
        if (ret < 0)
                return ret;