]> git.itanic.dy.fi Git - linux-stable/commitdiff
mmc: vub300: fix an error code
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 2 Nov 2023 07:51:06 +0000 (10:51 +0300)
committerUlf Hansson <ulf.hansson@linaro.org>
Fri, 3 Nov 2023 11:04:34 +0000 (12:04 +0100)
This error path should return -EINVAL instead of success.

Fixes: 88095e7b473a ("mmc: Add new VUB300 USB-to-SD/SDIO/MMC driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/0769d30c-ad80-421b-bf5d-7d6f5d85604e@moroto.mountain
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/vub300.c

index de3f443f5fdcc15879d07a0138193c69666d8e6c..fd67c0682b38ae0c4a4ed2dac2fe1f66e5af5f60 100644 (file)
@@ -2309,6 +2309,7 @@ static int vub300_probe(struct usb_interface *interface,
                vub300->read_only =
                        (0x0010 & vub300->system_port_status.port_flags) ? 1 : 0;
        } else {
+               retval = -EINVAL;
                goto error5;
        }
        usb_set_intfdata(interface, vub300);