]> git.itanic.dy.fi Git - linux-stable/commitdiff
wifi: rtw89: correct 5 MHz mask setting
authorEric Huang <echuang@realtek.com>
Thu, 6 Apr 2023 07:28:41 +0000 (15:28 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 5 Jun 2023 07:26:20 +0000 (09:26 +0200)
[ Upstream commit d33fc8d0368c180fe2338bfae4f5367a66a719f4 ]

Use primary channel index to determine which 5 MHz mask should be enable.
This mask is used to prevent noise from channel edge to effect CCA
threshold in wide bandwidth (>= 40 MHZ).

Fixes: 1b00e9236a71 ("rtw89: 8852c: add set channel of BB part")
Fixes: 6b0698984eb0 ("wifi: rtw89: 8852b: add chip_ops::set_channel")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Huang <echuang@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230406072841.8308-1-pkshih@realtek.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/realtek/rtw89/rtw8852c.c

index 67653b3e1a356f4e50b186dae3f87b2788670e42..3109114cec6ff1629138f994632665a88647a670 100644 (file)
@@ -1484,18 +1484,19 @@ static void rtw8852c_5m_mask(struct rtw89_dev *rtwdev,
                             const struct rtw89_chan *chan,
                             enum rtw89_phy_idx phy_idx)
 {
-       u8 pri_ch = chan->primary_channel;
+       u8 pri_ch = chan->pri_ch_idx;
        bool mask_5m_low;
        bool mask_5m_en;
 
        switch (chan->band_width) {
        case RTW89_CHANNEL_WIDTH_40:
                mask_5m_en = true;
-               mask_5m_low = pri_ch == 2;
+               mask_5m_low = pri_ch == RTW89_SC_20_LOWER;
                break;
        case RTW89_CHANNEL_WIDTH_80:
-               mask_5m_en = ((pri_ch == 3) || (pri_ch == 4));
-               mask_5m_low = pri_ch == 4;
+               mask_5m_en = pri_ch == RTW89_SC_20_UPMOST ||
+                            pri_ch == RTW89_SC_20_LOWEST;
+               mask_5m_low = pri_ch == RTW89_SC_20_LOWEST;
                break;
        default:
                mask_5m_en = false;