]> git.itanic.dy.fi Git - linux-stable/commitdiff
powerpc/mpc5xxx: Add missing fwnode_handle_put()
authorLiang He <windhl@126.com>
Wed, 22 Mar 2023 03:04:23 +0000 (11:04 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 24 Aug 2023 22:39:30 +0000 (08:39 +1000)
In mpc5xxx_fwnode_get_bus_frequency(), we should add
fwnode_handle_put() when break out of the iteration
fwnode_for_each_parent_node() as it will automatically
increase and decrease the refcounter.

Fixes: de06fba62af6 ("powerpc/mpc5xxx: Switch mpc5xxx_get_bus_frequency() to use fwnode")
Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20230322030423.1855440-1-windhl@126.com
arch/powerpc/sysdev/mpc5xxx_clocks.c

index c5bf7e1b37804bafd27ace7a5b7e83bd065a80e3..58cee28e23992a803a8d8bdfb649c63015017dca 100644 (file)
@@ -25,8 +25,10 @@ unsigned long mpc5xxx_fwnode_get_bus_frequency(struct fwnode_handle *fwnode)
 
        fwnode_for_each_parent_node(fwnode, parent) {
                ret = fwnode_property_read_u32(parent, "bus-frequency", &bus_freq);
-               if (!ret)
+               if (!ret) {
+                       fwnode_handle_put(parent);
                        return bus_freq;
+               }
        }
 
        return 0;