recordmcount: Fix memory leaks in the uwrite function

[ Upstream commit fa359d068574d29e7d2f0fdd0ebe4c6a12b5cfb9 ]

Common realloc mistake: 'file_append' nulled but not freed upon failure

Link: https://lkml.kernel.org/r/20230426010527.703093-1-zenghao@kylinos.cn
Signed-off-by: Hao Zeng <zenghao@kylinos.cn>
Suggested-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
index 9012e33ae22f86d35438044a8de50c90cdf1aa70..731600de0389312d3545772792cd17b45e7a39e2 100644 (file)
--- a/scripts/recordmcount.c
+++ b/scripts/recordmcount.c
@@ -146,6 +146,7 @@ uwrite(int const fd, void const *const buf, size_t const count)
 {
        size_t cnt = count;
        off_t idx = 0;
+       void *p = NULL;
 
        file_updated = 1;
 
@@ -153,7 +154,10 @@ uwrite(int const fd, void const *const buf, size_t const count)
                off_t aoffset = (file_ptr + count) - file_end;
 
                if (aoffset > file_append_size) {
-                       file_append = realloc(file_append, aoffset);
+                       p = realloc(file_append, aoffset);
+                       if (!p)
+                               free(file_append);
+                       file_append = p;
                        file_append_size = aoffset;
                }
                if (!file_append) {