]> git.itanic.dy.fi Git - linux-stable/commitdiff
powerpc: dts: turris1x.dts: Set lower priority for CPLD syscon-reboot
authorPali Rohár <pali@kernel.org>
Mon, 20 Feb 2023 08:04:35 +0000 (09:04 +0100)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 21 Feb 2023 04:56:24 +0000 (15:56 +1100)
Due to CPLD firmware bugs, set CPLD syscon-reboot priority level to 64
(between rstcr and watchdog) to ensure that rstcr's global-utilities reset
method which is preferred stay as default one, and to ensure that CPLD
syscon-reboot is more preferred than watchdog reset method.

Fixes: 0531a4abd1c6 ("powerpc: dts: turris1x.dts: Add CPLD reboot node")
Depends-on: e6333293f27c ("power: reset: syscon-reboot: Add support for specifying priority")
Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20230220080435.4237-1-pali@kernel.org
arch/powerpc/boot/dts/turris1x.dts

index e9cda34a140e0fb282b02f22d1b3b81d4d5376f1..c9b619f6ed5cb164333c5ed415b3ceb2fa76c7a6 100644 (file)
@@ -367,11 +367,34 @@ watchdog@2 {
                        };
 
                        reboot@d {
+                               /*
+                                * CPLD firmware which manages system reset and
+                                * watchdog registers has bugs. It does not
+                                * autoclear system reset register after change
+                                * and watchdog ignores reset line on immediate
+                                * succeeding reset cycle triggered by watchdog.
+                                * These bugs have to be workarounded in U-Boot
+                                * bootloader. So use system reset via syscon as
+                                * a last resort because older U-Boot versions
+                                * do not have workaround for watchdog.
+                                *
+                                * Reset method via rstcr's global-utilities
+                                * (the preferred one) has priority level 128,
+                                * watchdog has priority level 0 and default
+                                * syscon-reboot priority level is 192.
+                                *
+                                * So define syscon-reboot with custom priority
+                                * level 64 (between rstcr and watchdog) because
+                                * rstcr should stay as default preferred reset
+                                * method and reset via watchdog is more broken
+                                * than system reset via syscon.
+                                */
                                compatible = "syscon-reboot";
                                reg = <0x0d 0x01>;
                                offset = <0x0d>;
                                mask = <0x01>;
                                value = <0x01>;
+                               priority = <64>;
                        };
 
                        led-controller@13 {