gpio: rtd: Fix signedness bug in probe

The "data->irqs[]" array holds unsigned int so this error handling will
not work correctly.

Fixes: eee636bff0dc ("gpio: rtd: Add support for Realtek DHC(Digital Home Center) RTD SoCs")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

diff --git a/drivers/gpio/gpio-rtd.c b/drivers/gpio/gpio-rtd.c
index a7939bd0aa566e94ac5093e7fc494b7535623b9a..bf7f008f58d703347cba14f35c19f5798ee3a949 100644 (file)
--- a/drivers/gpio/gpio-rtd.c
+++ b/drivers/gpio/gpio-rtd.c
@@ -525,18 +525,21 @@ static int rtd_gpio_probe(struct platform_device *pdev)
        struct device *dev = &pdev->dev;
        struct gpio_irq_chip *irq_chip;
        struct rtd_gpio *data;
+       int ret;
 
        data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
        if (!data)
                return -ENOMEM;
 
-       data->irqs[0] = platform_get_irq(pdev, 0);
-       if (data->irqs[0] < 0)
-               return data->irqs[0];
+       ret = platform_get_irq(pdev, 0);
+       if (ret < 0)
+               return ret;
+       data->irqs[0] = ret;
 
-       data->irqs[1] = platform_get_irq(pdev, 1);
-       if (data->irqs[1] < 0)
-               return data->irqs[1];
+       ret = platform_get_irq(pdev, 1);
+       if (ret < 0)
+               return ret;
+       data->irqs[1] = ret;
 
        data->info = device_get_match_data(dev);
        if (!data->info)