]> git.itanic.dy.fi Git - linux-stable/commitdiff
PCI: endpoint: Fix double free in __pci_epc_create()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 25 Oct 2023 11:57:23 +0000 (14:57 +0300)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 26 Oct 2023 16:12:16 +0000 (11:12 -0500)
The pci_epc_release() function frees "epc" so the kfree() on the next line
is a double free.  Drop the redundant free.

Fixes: 7711cbb4862a ("PCI: endpoint: Fix WARN() when an endpoint driver is removed")
Link: https://lore.kernel.org/r/2ce68694-87a7-4c06-b8a4-9870c891b580@moroto.mountain
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
drivers/pci/endpoint/pci-epc-core.c

index 5a4a8b0be62625717822a9a3c64d3b3b04c3f490..a7d3a92391a418cac1387b1a3b246a9c631ad0bc 100644 (file)
@@ -869,7 +869,6 @@ __pci_epc_create(struct device *dev, const struct pci_epc_ops *ops,
 
 put_dev:
        put_device(&epc->dev);
-       kfree(epc);
 
 err_ret:
        return ERR_PTR(ret);