]> git.itanic.dy.fi Git - linux-stable/commitdiff
bonding: remove print in bond_verify_device_path
authorZhengchao Shao <shaozhengchao@huawei.com>
Thu, 23 Nov 2023 01:55:15 +0000 (09:55 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 5 Feb 2024 20:14:38 +0000 (20:14 +0000)
commit 486058f42a4728053ae69ebbf78e9731d8ce6f8b upstream.

As suggested by Paolo in link[1], if the memory allocation fails, the mm
layer will emit a lot warning comprising the backtrace, so remove the
print.

[1] https://lore.kernel.org/all/20231118081653.1481260-1-shaozhengchao@huawei.com/

Suggested-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/bonding/bond_main.c

index 9c1652886f4ecbe9b136d5f5bee67a73419fb4e1..8e6cc0e133b7f19afccd3ecf44bea5ceacb393b1 100644 (file)
@@ -2973,11 +2973,8 @@ struct bond_vlan_tag *bond_verify_device_path(struct net_device *start_dev,
 
        if (start_dev == end_dev) {
                tags = kcalloc(level + 1, sizeof(*tags), GFP_ATOMIC);
-               if (!tags) {
-                       net_err_ratelimited("%s: %s: Failed to allocate tags\n",
-                                           __func__, start_dev->name);
+               if (!tags)
                        return ERR_PTR(-ENOMEM);
-               }
                tags[level].vlan_proto = BOND_VLAN_PROTO_NONE;
                return tags;
        }