]> git.itanic.dy.fi Git - linux-stable/commitdiff
selftests: x86: fix [-Wstringop-overread] warn in test_process_vm_readv()
authorShuah Khan <skhan@linuxfoundation.org>
Thu, 21 Oct 2021 21:33:33 +0000 (15:33 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Jan 2022 14:23:31 +0000 (15:23 +0100)
commit dd40f44eabe1e122c6852fabb298aac05b083fce upstream.

Fix the following [-Wstringop-overread] by passing in the variable
instead of the value.

test_vsyscall.c: In function ‘test_process_vm_readv’:
test_vsyscall.c:500:22: warning: ‘__builtin_memcmp_eq’ specified bound 4096 exceeds source size 0 [-Wstringop-overread]
  500 |                 if (!memcmp(buf, (const void *)0xffffffffff600000, 4096)) {
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/testing/selftests/x86/test_vsyscall.c

index a4f4d4cf22c3b47c40acf7ae4c6d25d335e3b313..d0752a0a8f362032326081b64e240a52ebeb2688 100644 (file)
@@ -480,7 +480,7 @@ static int test_process_vm_readv(void)
        }
 
        if (vsyscall_map_r) {
-               if (!memcmp(buf, (const void *)0xffffffffff600000, 4096)) {
+               if (!memcmp(buf, remote.iov_base, sizeof(buf))) {
                        printf("[OK]\tIt worked and read correct data\n");
                } else {
                        printf("[FAIL]\tIt worked but returned incorrect data\n");