]> git.itanic.dy.fi Git - linux-stable/commitdiff
thermal/drivers/mediatek/lvts_thermal: Handle IRQ on all controllers
authorNícolas F. R. A. Prado <nfraprado@collabora.com>
Thu, 6 Jul 2023 15:37:32 +0000 (11:37 -0400)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Wed, 16 Aug 2023 07:54:31 +0000 (09:54 +0200)
There is a single IRQ handler for each LVTS thermal domain, and it is
supposed to check each of its underlying controllers for the origin of
the interrupt and clear its status. However due to a typo, only the
first controller was ever being handled, which resulted in the interrupt
never being cleared when it happened on the other controllers. Add the
missing index so interrupts are handled for all controllers.

Fixes: f5f633b18234 ("thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver")
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Tested-by: Chen-Yu Tsai <wenst@chromium.org>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230706153823.201943-2-nfraprado@collabora.com
drivers/thermal/mediatek/lvts_thermal.c

index 054c965ae5e11540e51aba26d4959e35ceab9e9d..4ec09cb8f667712b0a2a692528acb6041c3febf9 100644 (file)
@@ -451,7 +451,7 @@ static irqreturn_t lvts_irq_handler(int irq, void *data)
 
        for (i = 0; i < lvts_td->num_lvts_ctrl; i++) {
 
-               aux = lvts_ctrl_irq_handler(lvts_td->lvts_ctrl);
+               aux = lvts_ctrl_irq_handler(&lvts_td->lvts_ctrl[i]);
                if (aux != IRQ_HANDLED)
                        continue;