]> git.itanic.dy.fi Git - linux-stable/commitdiff
powerpc/512x: Add missing of_node_put() in clock-commonclk.c
authorLiang He <windhl@126.com>
Tue, 21 Jun 2022 08:03:49 +0000 (16:03 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 5 Sep 2022 07:30:24 +0000 (17:30 +1000)
In mpc5121_clk_provide_migration_support(), hold the reference returned
by of_find_compatible_node() and use it to call of_node_put() for refcount
balance.

Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220621080349.4081689-1-windhl@126.com
arch/powerpc/platforms/512x/clock-commonclk.c

index ca475462e95b142f6f3f1b84953fbd6c8fe4f66b..42abeba4f69832bc8c4eee0b972aedae9c00ee97 100644 (file)
@@ -950,7 +950,7 @@ static void __init mpc5121_clk_register_of_provider(struct device_node *np)
  */
 static void __init mpc5121_clk_provide_migration_support(void)
 {
-
+       struct device_node *np;
        /*
         * pre-enable those clock items which are not yet appropriately
         * acquired by their peripheral driver
@@ -970,7 +970,9 @@ static void __init mpc5121_clk_provide_migration_support(void)
         * unused and so it gets disabled
         */
        clk_prepare_enable(clks[MPC512x_CLK_PSC3_MCLK]);/* serial console */
-       if (of_find_compatible_node(NULL, "pci", "fsl,mpc5121-pci"))
+       np = of_find_compatible_node(NULL, "pci", "fsl,mpc5121-pci");
+       of_node_put(np);
+       if (np)
                clk_prepare_enable(clks[MPC512x_CLK_PCI]);
 }