]> git.itanic.dy.fi Git - linux-stable/commitdiff
OPP: Don't drop opp_table->np reference while it is still in use
authorLiang He <windhl@126.com>
Mon, 18 Jul 2022 13:36:31 +0000 (21:36 +0800)
committerViresh Kumar <viresh.kumar@linaro.org>
Tue, 19 Jul 2022 05:05:18 +0000 (10:35 +0530)
The OPP table contains a reference of the DT node, opp_table->np,
throughout its lifetime. We shouldn't drop the refcount for the same
from _of_init_opp_table(), but do that while removing the OPP table
finally.

Signed-off-by: Liang He <windhl@126.com>
[ Viresh: Updated subject / commit log and drop reference from
  _of_clear_opp_table() ]
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/opp/of.c

index 8367823a2001e69e0d9d230ee6716351779170f3..e4002b0754224882c6cffa2bb0a7bbe8cb3f1ce7 100644 (file)
@@ -242,12 +242,12 @@ void _of_init_opp_table(struct opp_table *opp_table, struct device *dev,
        opp_table->np = opp_np;
 
        _opp_table_alloc_required_tables(opp_table, dev, opp_np);
-       of_node_put(opp_np);
 }
 
 void _of_clear_opp_table(struct opp_table *opp_table)
 {
        _opp_table_free_required_tables(opp_table);
+       of_node_put(opp_table->np);
 }
 
 /*