]> git.itanic.dy.fi Git - linux-stable/commitdiff
macintosh: Add missing of_node_get() in do_attach()
authorLiang He <windhl@126.com>
Wed, 22 Jun 2022 06:16:52 +0000 (14:16 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 5 Sep 2022 07:30:24 +0000 (17:30 +1000)
We need a of_node_get() for of_find_compatible_node() to keep refcount
balance.

Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220622061652.4095330-1-windhl@126.com
drivers/macintosh/therm_windtunnel.c

index 091278240baa717e6aa768297784a30c2c281c39..5cd9671b2e3d2a1799a1490db7532dbc9bfa6ad1 100644 (file)
@@ -317,6 +317,7 @@ static void do_attach(struct i2c_adapter *adapter)
        if (x.running || strncmp(adapter->name, "uni-n", 5))
                return;
 
+       of_node_get(adapter->dev.of_node);
        np = of_find_compatible_node(adapter->dev.of_node, NULL, "MAC,ds1775");
        if (np) {
                of_node_put(np);
@@ -325,6 +326,7 @@ static void do_attach(struct i2c_adapter *adapter)
                i2c_new_scanned_device(adapter, &info, scan_ds1775, NULL);
        }
 
+       of_node_get(adapter->dev.of_node);
        np = of_find_compatible_node(adapter->dev.of_node, NULL, "MAC,adm1030");
        if (np) {
                of_node_put(np);