]> git.itanic.dy.fi Git - linux-stable/commitdiff
net: mdio-mux: show errors on probe failure
authorVladimir Oltean <vladimir.oltean@nxp.com>
Wed, 13 Dec 2023 15:27:11 +0000 (17:27 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 15 Dec 2023 02:55:38 +0000 (18:55 -0800)
Showing the precise error symbols can help debugging probe issues, such
as the recent -EIO error in of_mdiobus_register() caused by the lack of
bus->read_c45() and bus->write_c45() methods.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20231213152712.320842-2-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/mdio/mdio-mux.c

index bef4cce71287cea465fc0301b0a12b10bbf0ab15..e5dee7ad7c09d71bbd30afed71b65c9bff5990ec 100644 (file)
@@ -190,8 +190,8 @@ int mdio_mux_init(struct device *dev,
                r = of_property_read_u32(child_bus_node, "reg", &v);
                if (r) {
                        dev_err(dev,
-                               "Error: Failed to find reg for child %pOF\n",
-                               child_bus_node);
+                               "Error: Failed to find reg for child %pOF: %pe\n",
+                               child_bus_node, ERR_PTR(r));
                        continue;
                }
 
@@ -229,8 +229,8 @@ int mdio_mux_init(struct device *dev,
                        }
                        devm_kfree(dev, cb);
                        dev_err(dev,
-                               "Error: Failed to register MDIO bus for child %pOF\n",
-                               child_bus_node);
+                               "Error: Failed to register MDIO bus for child %pOF: %pe\n",
+                               child_bus_node, ERR_PTR(r));
                } else {
                        cb->next = pb->children;
                        pb->children = cb;