]> git.itanic.dy.fi Git - linux-stable/commitdiff
scsi: qla2xxx: Fix unused variable warning in qla2xxx_process_purls_pkt()
authorNathan Chancellor <nathan@kernel.org>
Tue, 29 Aug 2023 14:35:06 +0000 (07:35 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 31 Aug 2023 01:13:40 +0000 (21:13 -0400)
When CONFIG_NVME_FC is not set, fcport is unused:

  drivers/scsi/qla2xxx/qla_nvme.c: In function 'qla2xxx_process_purls_pkt':
  drivers/scsi/qla2xxx/qla_nvme.c:1183:20: warning: unused variable 'fcport' [-Wunused-variable]
   1183 |         fc_port_t *fcport = uctx->fcport;
        |                    ^~~~~~

While this preprocessor usage could be converted to a normal if
statement to allow the compiler to always see fcport as used, it is
equally easy to just eliminate the fcport variable and use uctx->fcport
directly.

Fixes: 27177862de96 ("scsi: qla2xxx: Fix nvme_fc_rcv_ls_req() undefined error")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/linux-next/20230828131304.269a2a40@canb.auug.org.au/
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202308290833.sKkoSSeO-lkp@intel.com/
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20230829-qla_nvme-fix-unused-fcport-v1-1-51c7560ecaee@kernel.org
Acked-by: Nilesh Javali <njavali@marvell.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_nvme.c

index 04e02de36100e1016aa62d19df77535729537814..db753d71299109dcb0b8601f50ba9093fca03e32 100644 (file)
@@ -1180,12 +1180,11 @@ static void
 qla2xxx_process_purls_pkt(struct scsi_qla_host *vha, struct purex_item *item)
 {
        struct qla_nvme_unsol_ctx *uctx = item->purls_context;
-       fc_port_t *fcport = uctx->fcport;
        struct qla_nvme_lsrjt_pt_arg a;
        int ret = 1;
 
 #if (IS_ENABLED(CONFIG_NVME_FC))
-       ret = nvme_fc_rcv_ls_req(fcport->nvme_remote_port, &uctx->lsrsp,
+       ret = nvme_fc_rcv_ls_req(uctx->fcport->nvme_remote_port, &uctx->lsrsp,
                                 &item->iocb, item->size);
 #endif
        if (ret) {