]> git.itanic.dy.fi Git - linux-stable/commitdiff
net: sunhme: Fix undersized zeroing of quattro->happy_meals
authorSean Anderson <seanga2@gmail.com>
Wed, 28 Sep 2022 00:41:57 +0000 (20:41 -0400)
committerJakub Kicinski <kuba@kernel.org>
Thu, 29 Sep 2022 02:18:42 +0000 (19:18 -0700)
Just use kzalloc instead.

Fixes: d6f1e89bdbb8 ("sunhme: Return an ERR_PTR from quattro_pci_find")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Sean Anderson <seanga2@gmail.com>
Link: https://lore.kernel.org/r/20220928004157.279731-1-seanga2@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/sun/sunhme.c

index 3afa73db500c5c41ed638f0bf75851f34367d9e2..62deed210a957047eac205689f9be1e63e79589a 100644 (file)
@@ -2409,12 +2409,10 @@ static struct quattro *quattro_sbus_find(struct platform_device *child)
        if (qp)
                return qp;
 
-       qp = kmalloc(sizeof(struct quattro), GFP_KERNEL);
+       qp = kzalloc(sizeof(*qp), GFP_KERNEL);
        if (!qp)
                return NULL;
 
-       memset(qp->happy_meals, 0, sizeof(*qp->happy_meals));
-
        qp->quattro_dev = child;
        qp->next = qfe_sbus_list;
        qfe_sbus_list = qp;