]> git.itanic.dy.fi Git - linux-stable/commitdiff
ext4: use sb_rdonly() helper for checking read-only flag
authorJan Kara <jack@suse.cz>
Fri, 16 Jun 2023 16:50:48 +0000 (18:50 +0200)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 29 Jul 2023 22:11:13 +0000 (18:11 -0400)
sb_rdonly() helper instead of directly checking sb->s_flags.

Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230616165109.21695-2-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/super.c

index ffc4fb73f133c7e76aadc00c0e4499dbe8ec7efa..19514f98e2fe8b34c2687fa882cb7e612e1f2368 100644 (file)
@@ -6084,7 +6084,7 @@ static void ext4_update_super(struct super_block *sb)
         * the clock is set in the future, and this will cause e2fsck
         * to complain and force a full file system check.
         */
-       if (!(sb->s_flags & SB_RDONLY))
+       if (!sb_rdonly(sb))
                ext4_update_tstamp(es, s_wtime);
        es->s_kbytes_written =
                cpu_to_le64(sbi->s_kbytes_written +
@@ -6675,7 +6675,7 @@ static int __ext4_remount(struct fs_context *fc, struct super_block *sb)
         * If there was a failing r/w to ro transition, we may need to
         * re-enable quota
         */
-       if ((sb->s_flags & SB_RDONLY) && !(old_sb_flags & SB_RDONLY) &&
+       if (sb_rdonly(sb) && !(old_sb_flags & SB_RDONLY) &&
            sb_any_quota_suspended(sb))
                dquot_resume(sb, -1);
        sb->s_flags = old_sb_flags;