]> git.itanic.dy.fi Git - linux-stable/commitdiff
bcachefs: snapshot: Add missing assignment in bch2_delete_dead_snapshots()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 15 Sep 2023 12:56:37 +0000 (15:56 +0300)
committerKent Overstreet <kent.overstreet@linux.dev>
Sun, 22 Oct 2023 21:10:14 +0000 (17:10 -0400)
This code accidentally left out the "ret = " assignment so the errors
from for_each_btree_key2() are not checked.

Fixes: 53534482a250 ("bcachefs: for_each_btree_key2()")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/snapshot.c

index ff7f71576d5c40b19b067ecc5d3b926ca0784533..0acfca00a6af99f40fa2b9c9bc58b863630c65fa 100644 (file)
@@ -1405,8 +1405,8 @@ int bch2_delete_dead_snapshots(struct bch_fs *c)
                goto err;
        }
 
-       for_each_btree_key2(trans, iter, BTREE_ID_snapshots,
-                          POS_MIN, 0, k,
+       ret = for_each_btree_key2(trans, iter, BTREE_ID_snapshots,
+                                 POS_MIN, 0, k,
                bch2_snapshot_set_equiv(trans, k));
        if (ret) {
                bch_err_msg(c, ret, "in bch2_snapshots_set_equiv");