]> git.itanic.dy.fi Git - linux-stable/commitdiff
ASoC: audio-graph-card2: fix off by one in graph_parse_node_multi_nm()
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 4 Dec 2023 12:42:07 +0000 (15:42 +0300)
committerMark Brown <broonie@kernel.org>
Thu, 7 Dec 2023 14:00:03 +0000 (14:00 +0000)
The > comparison should be >= to avoid writing one element beyond the end
of the dai_link->ch_maps[] array.  The dai_link->ch_maps[] array is
allocated in graph_parse_node_multi() and it has "nm_max" elements.

Fixes: e2de6808df4a ("ASoC: audio-graph-card2: add CPU:Codec = N:M support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/1032216f-902f-48f9-aa49-9d5ece8e87f2@moroto.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/generic/audio-graph-card2.c

index d9e10308a5081079b584916f362e37518bc1c022..78d9679decda7f951a768db1ff5186183a6f4990 100644 (file)
@@ -557,7 +557,7 @@ static int graph_parse_node_multi_nm(struct snd_soc_dai_link *dai_link,
                struct device_node *mcodec_port;
                int codec_idx;
 
-               if (*nm_idx > nm_max)
+               if (*nm_idx >= nm_max)
                        break;
 
                mcpu_ep_n = of_get_next_child(mcpu_port, mcpu_ep_n);