]> git.itanic.dy.fi Git - linux-stable/commitdiff
net: tso: inline tso_count_descs()
authorYunsheng Lin <linyunsheng@huawei.com>
Mon, 12 Dec 2022 03:24:26 +0000 (11:24 +0800)
committerJakub Kicinski <kuba@kernel.org>
Mon, 12 Dec 2022 23:04:39 +0000 (15:04 -0800)
tso_count_descs() is a small function doing simple calculation,
and tso_count_descs() is used in fast path, so inline it to
reduce the overhead of calls.

Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
Link: https://lore.kernel.org/r/20221212032426.16050-1-linyunsheng@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/tso.h
net/core/tso.c

index 62c98a9c60f15d7b4869f1ab523dfeb83fb18ba6..e7e157ae0526c8d655aca67a8a49191ec870746b 100644 (file)
@@ -2,6 +2,7 @@
 #ifndef _TSO_H
 #define _TSO_H
 
+#include <linux/skbuff.h>
 #include <net/ip.h>
 
 #define TSO_HEADER_SIZE                256
@@ -16,7 +17,12 @@ struct tso_t {
        u32     tcp_seq;
 };
 
-int tso_count_descs(const struct sk_buff *skb);
+/* Calculate the worst case buffer count */
+static inline int tso_count_descs(const struct sk_buff *skb)
+{
+       return skb_shinfo(skb)->gso_segs * 2 + skb_shinfo(skb)->nr_frags;
+}
+
 void tso_build_hdr(const struct sk_buff *skb, char *hdr, struct tso_t *tso,
                   int size, bool is_last);
 void tso_build_data(const struct sk_buff *skb, struct tso_t *tso, int size);
index 4148f6d48953e1e1ebd878c3953f3e41d47832d9..e00796e3b146a506cb2c37d0d77ca1a6e2548d32 100644 (file)
@@ -5,14 +5,6 @@
 #include <net/tso.h>
 #include <asm/unaligned.h>
 
-/* Calculate expected number of TX descriptors */
-int tso_count_descs(const struct sk_buff *skb)
-{
-       /* The Marvell Way */
-       return skb_shinfo(skb)->gso_segs * 2 + skb_shinfo(skb)->nr_frags;
-}
-EXPORT_SYMBOL(tso_count_descs);
-
 void tso_build_hdr(const struct sk_buff *skb, char *hdr, struct tso_t *tso,
                   int size, bool is_last)
 {