]> git.itanic.dy.fi Git - linux-stable/commitdiff
crypto: rsa - add a check for allocation failure
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 30 Oct 2023 09:02:59 +0000 (12:02 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 17 Nov 2023 11:16:29 +0000 (19:16 +0800)
Static checkers insist that the mpi_alloc() allocation can fail so add
a check to prevent a NULL dereference.  Small allocations like this
can't actually fail in current kernels, but adding a check is very
simple and makes the static checkers happy.

Fixes: 6637e11e4ad2 ("crypto: rsa - allow only odd e and restrict value in FIPS mode")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/rsa.c

index c79613cdce6e443aacdc4477315e4765a9210990..b9cd11fb7d3672245f49960901f349e3efe16c2f 100644 (file)
@@ -220,6 +220,8 @@ static int rsa_check_exponent_fips(MPI e)
        }
 
        e_max = mpi_alloc(0);
+       if (!e_max)
+               return -ENOMEM;
        mpi_set_bit(e_max, 256);
 
        if (mpi_cmp(e, e_max) >= 0) {