]> git.itanic.dy.fi Git - linux-stable/commitdiff
rpmsg: glink: Release driver_override
authorBjorn Andersson <quic_bjorande@quicinc.com>
Tue, 31 Oct 2023 11:39:51 +0000 (11:39 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Nov 2023 10:22:19 +0000 (11:22 +0100)
commit fb80ef67e8ff6a00d3faad4cb348dafdb8eccfd8 upstream.

Upon termination of the rpmsg_device, driver_override needs to be freed
to avoid leaking the potentially assigned string.

Fixes: 42cd402b8fd4 ("rpmsg: Fix kfree() of static memory on setting driver_override")
Fixes: 39e47767ec9b ("rpmsg: Add driver_override device attribute for rpmsg_device")
Reviewed-by: Chris Lew <quic_clew@quicinc.com>
Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230109223931.1706429-1-quic_bjorande@quicinc.com
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/rpmsg/qcom_glink_native.c

index 02e39778d3c6b42c87986374559ee6e2198674bb..48d2fb187a1bf36ff557f95a268d6564a04349bc 100644 (file)
@@ -1379,6 +1379,7 @@ static void qcom_glink_rpdev_release(struct device *dev)
        struct glink_channel *channel = to_glink_channel(rpdev->ept);
 
        channel->rpdev = NULL;
+       kfree(rpdev->driver_override);
        kfree(rpdev);
 }