]> git.itanic.dy.fi Git - linux-stable/commitdiff
usb: add quirks for Lenovo OneLink+ Dock
authorJean-Francois Le Fillatre <jflf_kernel@gmx.com>
Wed, 24 Aug 2022 19:13:21 +0000 (21:13 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Sep 2022 09:04:02 +0000 (11:04 +0200)
[ Upstream commit 3d5f70949f1b1168fbb17d06eb5c57e984c56c58 ]

The Lenovo OneLink+ Dock contains two VL812 USB3.0 controllers:
17ef:1018 upstream
17ef:1019 downstream

Those two controllers both have problems with some USB3.0 devices,
particularly self-powered ones. Typical error messages include:

  Timeout while waiting for setup device command
  device not accepting address X, error -62
  unable to enumerate USB device

By process of elimination the controllers themselves were identified as
the cause of the problem. Through trial and error the issue was solved
by using USB_QUIRK_RESET_RESUME for both chips.

Signed-off-by: Jean-Francois Le Fillatre <jflf_kernel@gmx.com>
Cc: stable <stable@kernel.org>
Link: https://lore.kernel.org/r/20220824191320.17883-1-jflf_kernel@gmx.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/core/quirks.c

index f8f2de7899a94be0364fceea33999ae23156b6d7..dd7947547054aa79bebd6cefa9141dab8aee4056 100644 (file)
@@ -438,6 +438,10 @@ static const struct usb_device_id usb_quirk_list[] = {
        { USB_DEVICE(0x1532, 0x0116), .driver_info =
                        USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
 
+       /* Lenovo ThinkPad OneLink+ Dock twin hub controllers (VIA Labs VL812) */
+       { USB_DEVICE(0x17ef, 0x1018), .driver_info = USB_QUIRK_RESET_RESUME },
+       { USB_DEVICE(0x17ef, 0x1019), .driver_info = USB_QUIRK_RESET_RESUME },
+
        /* Lenovo USB-C to Ethernet Adapter RTL8153-04 */
        { USB_DEVICE(0x17ef, 0x720c), .driver_info = USB_QUIRK_NO_LPM },