]> git.itanic.dy.fi Git - linux-stable/commitdiff
pwm: atmel-hlcdc: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 23 Oct 2023 17:46:18 +0000 (19:46 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Wed, 20 Dec 2023 15:04:13 +0000 (16:04 +0100)
This macro has the advantage over SIMPLE_DEV_PM_OPS that we don't have to
care about when the functions are actually used, so the corresponding
#ifdef can be dropped.

Also make use of pm_ptr() to discard all PM related stuff if CONFIG_PM
isn't enabled.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-atmel-hlcdc.c

index 07920e0347575aeb420c303c93fdd3ae99dc8448..3f2c5031a3ba85fd756f02a17b63739fd4575256 100644 (file)
@@ -180,7 +180,6 @@ static const struct atmel_hlcdc_pwm_errata atmel_hlcdc_pwm_sama5d3_errata = {
        .div1_clk_erratum = true,
 };
 
-#ifdef CONFIG_PM_SLEEP
 static int atmel_hlcdc_pwm_suspend(struct device *dev)
 {
        struct atmel_hlcdc_pwm *atmel = dev_get_drvdata(dev);
@@ -210,10 +209,9 @@ static int atmel_hlcdc_pwm_resume(struct device *dev)
        return atmel_hlcdc_pwm_apply(&atmel->chip, &atmel->chip.pwms[0],
                                     &state);
 }
-#endif
 
-static SIMPLE_DEV_PM_OPS(atmel_hlcdc_pwm_pm_ops,
-                        atmel_hlcdc_pwm_suspend, atmel_hlcdc_pwm_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(atmel_hlcdc_pwm_pm_ops,
+                               atmel_hlcdc_pwm_suspend, atmel_hlcdc_pwm_resume);
 
 static const struct of_device_id atmel_hlcdc_dt_ids[] = {
        {
@@ -297,7 +295,7 @@ static struct platform_driver atmel_hlcdc_pwm_driver = {
        .driver = {
                .name = "atmel-hlcdc-pwm",
                .of_match_table = atmel_hlcdc_pwm_dt_ids,
-               .pm = &atmel_hlcdc_pwm_pm_ops,
+               .pm = pm_ptr(&atmel_hlcdc_pwm_pm_ops),
        },
        .probe = atmel_hlcdc_pwm_probe,
        .remove_new = atmel_hlcdc_pwm_remove,