powerpc/sysdev/fsl_msi: Add missing of_node_put()

In fsl_setup_msi_irqs(), use of_node_put() to drop the reference
returned by of_parse_phandle().

Fixes: 895d603f945ba ("powerpc/fsl_msi: add support for the fsl, msi property in PCI nodes")
Co-authored-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220704145233.278539-1-windhl@126.com

diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c
index ef9a5999fa93ddfef9e8851701a8a2d517c60761..73c2d70706c0add48ea9553fec807c6953cb5a7d 100644 (file)
--- a/arch/powerpc/sysdev/fsl_msi.c
+++ b/arch/powerpc/sysdev/fsl_msi.c
@@ -209,8 +209,10 @@ static int fsl_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type)
                        dev_err(&pdev->dev,
                                "node %pOF has an invalid fsl,msi phandle %u\n",
                                hose->dn, np->phandle);
+                       of_node_put(np);
                        return -EINVAL;
                }
+               of_node_put(np);
        }
 
        msi_for_each_desc(entry, &pdev->dev, MSI_DESC_NOTASSOCIATED) {