]> git.itanic.dy.fi Git - linux-stable/commitdiff
usb: gadget: net2272: Use irqflags in the call to net2272_probe_fin
authorColin Ian King <colin.i.king@gmail.com>
Thu, 7 Mar 2024 18:17:34 +0000 (18:17 +0000)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:17:30 +0000 (18:17 -0400)
[ Upstream commit 600556809f04eb3bbccd05218215dcd7b285a9a9 ]

Currently the variable irqflags is being set but is not being used,
it appears it should be used in the call to net2272_probe_fin
rather than IRQF_TRIGGER_LOW being used. Kudos to Uwe Kleine-König
for suggesting the fix.

Cleans up clang scan build warning:
drivers/usb/gadget/udc/net2272.c:2610:15: warning: variable 'irqflags'
set but not used [-Wunused-but-set-variable]

Fixes: ceb80363b2ec ("USB: net2272: driver for PLX NET2272 USB device controller")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20240307181734.2034407-1-colin.i.king@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/gadget/udc/net2272.c

index 12e76bb62c20944f902ab33b04691d266e9365a7..19bbc38f3d35dc7977dde74d67eec7e5908834e5 100644 (file)
@@ -2650,7 +2650,7 @@ net2272_plat_probe(struct platform_device *pdev)
                goto err_req;
        }
 
-       ret = net2272_probe_fin(dev, IRQF_TRIGGER_LOW);
+       ret = net2272_probe_fin(dev, irqflags);
        if (ret)
                goto err_io;