]> git.itanic.dy.fi Git - linux-stable/commitdiff
I2C: ali15x3: Do PCI error checks on own line
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Sun, 27 Aug 2023 13:37:02 +0000 (16:37 +0300)
committerWolfram Sang <wsa@kernel.org>
Wed, 30 Aug 2023 19:18:35 +0000 (21:18 +0200)
Instead of if conditions with line splits, use the usual error handling
pattern with a separate variable to improve readability.

No functional changes intended.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-ali15x3.c

index cc58feacd08212b792d486f4d455a764d6e9bb81..0231c5be6354f4ff40b2dc0c8ab57bd191511e3c 100644 (file)
@@ -165,14 +165,15 @@ static int ali15x3_setup(struct pci_dev *ALI15X3_dev)
        }
 
        if(force_addr) {
+               int ret;
+
                dev_info(&ALI15X3_dev->dev, "forcing ISA address 0x%04X\n",
                        ali15x3_smba);
-               if (PCIBIOS_SUCCESSFUL != pci_write_config_word(ALI15X3_dev,
-                                                               SMBBA,
-                                                               ali15x3_smba))
+               ret = pci_write_config_word(ALI15X3_dev, SMBBA, ali15x3_smba);
+               if (ret != PCIBIOS_SUCCESSFUL)
                        goto error;
-               if (PCIBIOS_SUCCESSFUL != pci_read_config_word(ALI15X3_dev,
-                                                               SMBBA, &a))
+               ret = pci_read_config_word(ALI15X3_dev, SMBBA, &a);
+               if (ret != PCIBIOS_SUCCESSFUL)
                        goto error;
                if ((a & ~(ALI15X3_SMB_IOSIZE - 1)) != ali15x3_smba) {
                        /* make sure it works */