bonding: do failover when high prio link up

Currently, when a high prio link enslaved, or when current link down,
the high prio port could be selected. But when high prio link up, the
new active slave reselection is not triggered. Fix it by checking link's
prio when getting up. Making the do_failover after looping all slaves as
there may be multi high prio slaves up.

Reported-by: Liang Li <liali@redhat.com>
Fixes: 0a2ff7cc8ad4 ("Bonding: add per-port priority for failover re-selection")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 6a4bbd5aa3e0951e05990be6cce6950221c812bc..b4c65783960a5aa14de5d64aeea190f02a04be44 100644 (file)
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -2654,8 +2654,9 @@ static void bond_miimon_link_change(struct bonding *bond,
 
 static void bond_miimon_commit(struct bonding *bond)
 {
-       struct list_head *iter;
        struct slave *slave, *primary;
+       bool do_failover = false;
+       struct list_head *iter;
 
        bond_for_each_slave(bond, slave, iter) {
                switch (slave->link_new_state) {
@@ -2699,8 +2700,9 @@ static void bond_miimon_commit(struct bonding *bond)
 
                        bond_miimon_link_change(bond, slave, BOND_LINK_UP);
 
-                       if (!rcu_access_pointer(bond->curr_active_slave) || slave == primary)
-                               goto do_failover;
+                       if (!rcu_access_pointer(bond->curr_active_slave) || slave == primary ||
+                           slave->prio > rcu_dereference(bond->curr_active_slave)->prio)
+                               do_failover = true;
 
                        continue;
 
@@ -2721,7 +2723,7 @@ static void bond_miimon_commit(struct bonding *bond)
                        bond_miimon_link_change(bond, slave, BOND_LINK_DOWN);
 
                        if (slave == rcu_access_pointer(bond->curr_active_slave))
-                               goto do_failover;
+                               do_failover = true;
 
                        continue;
 
@@ -2732,8 +2734,9 @@ static void bond_miimon_commit(struct bonding *bond)
 
                        continue;
                }
+       }
 
-do_failover:
+       if (do_failover) {
                block_netpoll_tx();
                bond_select_active_slave(bond);
                unblock_netpoll_tx();
@@ -3531,6 +3534,7 @@ static int bond_ab_arp_inspect(struct bonding *bond)
  */
 static void bond_ab_arp_commit(struct bonding *bond)
 {
+       bool do_failover = false;
        struct list_head *iter;
        unsigned long last_tx;
        struct slave *slave;
@@ -3560,8 +3564,9 @@ static void bond_ab_arp_commit(struct bonding *bond)
                                slave_info(bond->dev, slave->dev, "link status definitely up\n");
 
                                if (!rtnl_dereference(bond->curr_active_slave) ||
-                                   slave == rtnl_dereference(bond->primary_slave))
-                                       goto do_failover;
+                                   slave == rtnl_dereference(bond->primary_slave) ||
+                                   slave->prio > rtnl_dereference(bond->curr_active_slave)->prio)
+                                       do_failover = true;
 
                        }
 
@@ -3580,7 +3585,7 @@ static void bond_ab_arp_commit(struct bonding *bond)
 
                        if (slave == rtnl_dereference(bond->curr_active_slave)) {
                                RCU_INIT_POINTER(bond->current_arp_slave, NULL);
-                               goto do_failover;
+                               do_failover = true;
                        }
 
                        continue;
@@ -3604,8 +3609,9 @@ static void bond_ab_arp_commit(struct bonding *bond)
                                  slave->link_new_state);
                        continue;
                }
+       }
 
-do_failover:
+       if (do_failover) {
                block_netpoll_tx();
                bond_select_active_slave(bond);
                unblock_netpoll_tx();