]> git.itanic.dy.fi Git - linux-stable/commitdiff
pwm: samsung: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 23 Oct 2023 17:46:24 +0000 (19:46 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Wed, 20 Dec 2023 15:04:13 +0000 (16:04 +0100)
This macro has the advantage over SIMPLE_DEV_PM_OPS that we don't have to
care about when the functions are actually used, so the corresponding
#ifdef can be dropped.

Also make use of pm_ptr() to discard all PM related stuff if CONFIG_PM
isn't enabled.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-samsung.c

index 69d9f4577b3479fd6038b7e71cc56cfff48fa7c2..6e77302f73687f5ac4e63b1a00663b639772264b 100644 (file)
@@ -620,7 +620,6 @@ static void pwm_samsung_remove(struct platform_device *pdev)
        clk_disable_unprepare(our_chip->base_clk);
 }
 
-#ifdef CONFIG_PM_SLEEP
 static int pwm_samsung_resume(struct device *dev)
 {
        struct samsung_pwm_chip *our_chip = dev_get_drvdata(dev);
@@ -653,14 +652,13 @@ static int pwm_samsung_resume(struct device *dev)
 
        return 0;
 }
-#endif
 
-static SIMPLE_DEV_PM_OPS(pwm_samsung_pm_ops, NULL, pwm_samsung_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(pwm_samsung_pm_ops, NULL, pwm_samsung_resume);
 
 static struct platform_driver pwm_samsung_driver = {
        .driver         = {
                .name   = "samsung-pwm",
-               .pm     = &pwm_samsung_pm_ops,
+               .pm     = pm_ptr(&pwm_samsung_pm_ops),
                .of_match_table = of_match_ptr(samsung_pwm_matches),
        },
        .probe          = pwm_samsung_probe,