]> git.itanic.dy.fi Git - linux-stable/commitdiff
net: dsa: tag_ocelot: do not rely on skb_mac_header() for VLAN xmit
authorVladimir Oltean <vladimir.oltean@nxp.com>
Thu, 20 Apr 2023 22:55:56 +0000 (01:55 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sun, 23 Apr 2023 13:16:44 +0000 (14:16 +0100)
skb_mac_header() will no longer be available in the TX path when
reverting commit 6d1ccff62780 ("net: reset mac header in
dev_start_xmit()"). As preparation for that, let's use
skb_vlan_eth_hdr() to get to the VLAN header instead, which assumes it's
located at skb->data (assumption which holds true here).

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/tag_ocelot.c

index 28ebecafdd24b8665000907f1e976aca5fbd5360..73ee09de1a3a9ebe9b45ba5d24edfa19c663e587 100644 (file)
@@ -26,7 +26,7 @@ static void ocelot_xmit_get_vlan_info(struct sk_buff *skb, struct dsa_port *dp,
                return;
        }
 
-       hdr = (struct vlan_ethhdr *)skb_mac_header(skb);
+       hdr = skb_vlan_eth_hdr(skb);
        br_vlan_get_proto(br, &proto);
 
        if (ntohs(hdr->h_vlan_proto) == proto) {