]> git.itanic.dy.fi Git - linux-stable/commitdiff
net: sungem_phy: Add of_node_put() for reference returned by of_get_parent()
authorLiang He <windhl@126.com>
Wed, 20 Jul 2022 13:10:03 +0000 (21:10 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 22 Jul 2022 02:04:19 +0000 (19:04 -0700)
In bcm5421_init(), we should call of_node_put() for the reference
returned by of_get_parent() which has increased the refcount.

Fixes: 3c326fe9cb7a ("[PATCH] ppc64: Add new PHY to sungem")
Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220720131003.1287426-1-windhl@126.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/sungem_phy.c

index ff22b6b1c6861b8979f663cef5442307ae026304..36803d932dff47248ef92b9f10597c50010eb6f2 100644 (file)
@@ -450,6 +450,7 @@ static int bcm5421_init(struct mii_phy* phy)
                int can_low_power = 1;
                if (np == NULL || of_get_property(np, "no-autolowpower", NULL))
                        can_low_power = 0;
+               of_node_put(np);
                if (can_low_power) {
                        /* Enable automatic low-power */
                        sungem_phy_write(phy, 0x1c, 0x9002);