]> git.itanic.dy.fi Git - linux-stable/commitdiff
ALSA: hda: cs35l41: Do not allow uninitialised variables to be freed
authorStefan Binding <sbinding@opensource.cirrus.com>
Tue, 19 Dec 2023 16:22:31 +0000 (16:22 +0000)
committerTakashi Iwai <tiwai@suse.de>
Thu, 21 Dec 2023 08:23:51 +0000 (09:23 +0100)
Initialise the variables to NULL so that they cannot be uninitialised
when devm_kfree is called.

Found by static analysis.

Fixes: 8c4c216db8fb ("ALSA: hda: cs35l41: Add config table to support many laptops without _DSD")
Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20231219162232.790358-2-sbinding@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/cs35l41_hda_property.c

index c9eb702909733bcc1320d9d4b5948ed41a98ce3c..73b304e6c83c7aa39c0b85e8a2940d9b55270a60 100644 (file)
@@ -77,10 +77,10 @@ static const struct cs35l41_config cs35l41_config_table[] = {
 static int cs35l41_add_gpios(struct cs35l41_hda *cs35l41, struct device *physdev, int reset_gpio,
                             int spkid_gpio, int cs_gpio_index, int num_amps)
 {
-       struct acpi_gpio_mapping *gpio_mapping;
-       struct acpi_gpio_params *reset_gpio_params;
-       struct acpi_gpio_params *spkid_gpio_params;
-       struct acpi_gpio_params *cs_gpio_params;
+       struct acpi_gpio_mapping *gpio_mapping = NULL;
+       struct acpi_gpio_params *reset_gpio_params = NULL;
+       struct acpi_gpio_params *spkid_gpio_params = NULL;
+       struct acpi_gpio_params *cs_gpio_params = NULL;
        unsigned int num_entries = 0;
        unsigned int reset_index, spkid_index, csgpio_index;
        int i;