]> git.itanic.dy.fi Git - linux-stable/commitdiff
media: ov2740: Add a sleep after resetting the sensor
authorHans de Goede <hdegoede@redhat.com>
Mon, 4 Dec 2023 12:39:45 +0000 (13:39 +0100)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 13 Dec 2023 12:21:20 +0000 (13:21 +0100)
Split the resetting of the sensor out of the link_freq_config reg_list
and add a delay after this.

This hopefully fixes the stream sometimes not starting, this was
taken from the ov2740 sensor driver in the out of tree IPU6 driver:

https://github.com/intel/ipu6-drivers/

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/i2c/ov2740.c

index 3c58a6e0d7a08aaf0c522dd4b18a1b9891e70754..552935ccb4a90490685b9d07ba016df8516d8162 100644 (file)
@@ -128,7 +128,6 @@ struct ov2740_mode {
 };
 
 static const struct ov2740_reg mipi_data_rate_720mbps[] = {
-       {0x0103, 0x01},
        {0x0302, 0x4b},
        {0x030d, 0x4b},
        {0x030e, 0x02},
@@ -137,7 +136,6 @@ static const struct ov2740_reg mipi_data_rate_720mbps[] = {
 };
 
 static const struct ov2740_reg mipi_data_rate_360mbps[] = {
-       {0x0103, 0x01},
        {0x0302, 0x4b},
        {0x0303, 0x01},
        {0x030d, 0x4b},
@@ -935,6 +933,15 @@ static int ov2740_start_streaming(struct ov2740 *ov2740)
        if (ov2740->nvm)
                ov2740_load_otp_data(ov2740->nvm);
 
+       /* Reset the sensor */
+       ret = ov2740_write_reg(ov2740, 0x0103, 1, 0x01);
+       if (ret) {
+               dev_err(&client->dev, "failed to reset\n");
+               return ret;
+       }
+
+       usleep_range(10000, 15000);
+
        link_freq_index = ov2740->cur_mode->link_freq_index;
        reg_list = &link_freq_configs[link_freq_index].reg_list;
        ret = ov2740_write_reg_list(ov2740, reg_list);